[mesheryctl] Fall back to stable release #1886
Conversation
- Releases with patch, alpha, beta, and rc will not generate tar files. install script needs to check with meshery repo for the latest stable release before continue Signed-off-by: Phuong Dao <[email protected]>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. |
github-actions
bot
added
area/lifecycle
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@da0p, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
|
@Ashparshp Thanks! Is there another way we can discuss it? I am usually not available at the time of the websites meeting |
| LAST_MESHERY_VERSION=`echo $MESHERY_VERSION | awk -F '-patch' '{print $1}'` | ||
| # For patch/alpha/beta/rc releases, the meshery tar ball will not be generated, so fall back to last stable release | ||
| if [[ "$MESHERY_VERSION" =~ .+-(patch|alpha|beta|rc) ]] ; then | ||
| LAST_MESHERY_VERSION=$(git ls-remote --tags https://github.com/meshery/meshery | grep -v -E 'patch|alpha|beta|rc' | tail -1 | sed -E "s/(.+)(v.+)/\2/") |
There was a problem hiding this comment.
This introduces dependency on git command. We need to add a command_exists check for git as well.
We wanted to get away from git API calls also, but looks like its unavoidable, unless we support another direct API to get last stable build similar to "https://docs.meshery.io/project/releases/latest"
Please check whats the issue with the latest beta release, as we had tar balls available for beta and rc builds earlier.
#1704 (comment)
Also, the earlier fix wont work, if the patch release is >1 or the base version's tar is not available.
There was a problem hiding this comment.
@da0p will you be incorporating this feedback?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
issue/stale
stale
bot
removed
the
issue/stale
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
issue/stale
|
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
This PR fixes:
build-and-release-stable.yml only builds tar if the tags do not contain the suffices: patch, alpha, beta, rc. However, [install] (https://github.com/meshery/meshery.io/blob/master/install) script in meshery.io only strips the patch suffix, leading to being unable to install meshery if there is no tar of the same version, for example
This PR uses git ls-remote to query the latest tags of meshery and exclude all the tags with suffices alpha, beta, patch, and rc